[Merged by Bors] - disable k8 if build image_version is supplied #1400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use proxy for minikube running in mac
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 8, 2021
This is for #1363. Disable building image if image version is supplied. This is useful in the Mac where building image might not work. In this case, we use image supplied built using Linux. Also, by default use proxy for accessing Minikube cluster since Docker for Mac doesn't map ports from Minikube to host automatically.
|
bors r- |
|
Canceled. |
add image option and proxy test
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 8, 2021
This is for #1363. Disable building image if image version is supplied. This is useful in the Mac where building image might not work. In this case, we use image supplied built using Linux. Also, by default use proxy for accessing Minikube cluster since Docker for Mac doesn't map ports from Minikube to host automatically.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for #1363.
Disable building image if image version is supplied. This is useful in the Mac where building image might not work. In this case, we use image supplied built using Linux.
Also, by default use proxy for accessing Minikube cluster since Docker for Mac doesn't map ports from Minikube to host automatically.