Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: fvm install help command with usage example #3629

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - feat: fvm install help command with usage example #3629

wants to merge 2 commits into from

Conversation

EstebanBorai
Copy link
Contributor

Provides better help message for fvm install and also introduces Usage examples.

Demo

CleanShot 2023-10-26 at 11 18 51

@EstebanBorai EstebanBorai linked an issue Oct 26, 2023 that may be closed by this pull request
FVM - Improve fvm install help command #3623
Closed
@ajhunyady
Copy link
Contributor

Awesome! Thank you.

digikata
digikata approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@digikata digikata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice!

@EstebanBorai
Copy link
Contributor Author

bors r+

bors bot pushed a commit that referenced this pull request Oct 26, 2023
@EstebanBorai
feat: fvm install help command with usage example (#3629)
911726a 
Provides better help message for `fvm install` and also introduces `Usage` examples.

## Demo

![CleanShot 2023-10-26 at 11 18 51](https://github.com/infinyon/fluvio/assets/34756077/24a44c64-81a8-49f0-b3e9-7d2f69ada360)
@bors
Copy link

bors bot commented Oct 26, 2023

Build failed:

@EstebanBorai
Copy link
Contributor Author

Build failed:

Cluster timeout. Retrying...

@EstebanBorai
Copy link
Contributor Author

bors r+

bors bot pushed a commit that referenced this pull request Oct 26, 2023
@EstebanBorai
feat: fvm install help command with usage example (#3629)
d891dd9 
Provides better help message for `fvm install` and also introduces `Usage` examples.

## Demo

![CleanShot 2023-10-26 at 11 18 51](https://github.com/infinyon/fluvio/assets/34756077/24a44c64-81a8-49f0-b3e9-7d2f69ada360)
@bors
Copy link

bors bot commented Oct 26, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: fvm install help command with usage example [Merged by Bors] - feat: fvm install help command with usage example Oct 26, 2023
@bors bors bot closed this Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digikata digikata digikata approved these changes

@ajhunyady ajhunyady Awaiting requested review from ajhunyady

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FVM - Improve fvm install help command
3 participants
@EstebanBorai @ajhunyady @digikata