[Merged by Bors] - feat: fvm update command #3645
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
EstebanBorai
force-pushed
the
3644-fvm-update-command
branch
2 times, most recently
from
5ce57bc
to
719631b
Compare
EstebanBorai
force-pushed
the
3644-fvm-update-command
branch
from
719631b
to
68e593c
Compare
|
What happens if I run |
You will see: |
EstebanBorai
force-pushed
the
3644-fvm-update-command
branch
from
68e593c
to
b592395
Compare
Just added a test for this here: b592395#diff-9e90aaedcb1d6ed2a0448f1c8fb5306d2c9788f1ed82e0d22619efb9f2f277e2R745-R768 |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Nov 1, 2023
Introduces the `fvm update` command which checks current channel to be up to date. Channels `stable` and `latest` are both "updateable", in the other hand the static tag is not "updateable". ### How it works When a user has either `stable` or `latest` as the active channel, FVM fetches the most recent release for that channel. - Stable: Will check if the upstream version is greater than the current using Semver. - Latest: Will check if the upstream tag is different. We cant tell which is greater because we use SHAs to determine versions. - Static Tag: When the user has an static tag as version using for instance `fvm install 0.10.14`, FVM will not attempt to update. Then the same process as for `fvm install` is followed, this is why the logic is first disengaged from `fvm install` into its own module on commit: [0a8b819](0a8b819). In order to determine the current version for the channel FVM uses the already implemented `settings.toml` file. ## Demo  > By changing the version in the settings.toml, we can mimic an outdated version for the active channel.
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces the
fvm updatecommand which checks current channel to be up to date.Channels
stableandlatestare both "updateable", in the other hand the statictag is not "updateable".
How it works
When a user has either
stableorlatestas the active channel, FVM fetches the mostrecent release for that channel.
fvm install 0.10.14, FVM will not attempt to update.Then the same process as for
fvm installis followed, this is why the logic is firstdisengaged from
fvm installinto its own module on commit: 0a8b819.In order to determine the current version for the channel FVM uses the already implemented
settings.tomlfile.Demo