CLI cluster install changes #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- updated description - updated launching SPU statement - display log locations for SC and SPU for local
sehz
reviewed
Jun 8, 2020
src/cli/src/cluster/install/local.rs
Outdated
| @@ -170,7 +171,7 @@ async fn launch_spu(spu_index: u16, client: SharedK8Client, option: &InstallComm | |||
| .print(); | |||
|
|
|||
| println!("SPU<{}> cmd: {:#?}", spu_index, cmd); | |||
|
|
|||
| println!("SPU log generated at /tmp/spu_log_{}.log", spu_id); | |||
There was a problem hiding this comment.
So logic duplicated here. Can you assign location of the log then just reuse here? for example:
let log = format!("/tmp/spu_log_{},spu_id);
....
println!("SPU log generated at {}", log);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #36 cl- updated description