Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update to go1.20 #6026

Merged
merged 4 commits into from
Feb 28, 2023
Merged

chore: Update to go1.20 #6026

merged 4 commits into from
Feb 28, 2023

Conversation

jeffreyssmith2nd
Copy link
Contributor

No description provided.

@jeffreyssmith2nd jeffreyssmith2nd marked this pull request as ready for review February 28, 2023 19:57
davidby-influx
davidby-influx requested changes Feb 28, 2023
View reviewed changes
Copy link

@davidby-influx davidby-influx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't go.mod also need to increment to 1.20 ?

@jeffreyssmith2nd
Copy link
Contributor Author

Doesn't go.mod also need to increment to 1.20 ?

Thank you, I knew I was missing something.

jdstrand
jdstrand approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@jdstrand jdstrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for updating alpine in the Dockerfile too! :)

davidby-influx
davidby-influx requested changes Feb 28, 2023
View reviewed changes
Copy link

@davidby-influx davidby-influx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go.sum and go mod vendor updates?

@jeffreyssmith2nd
Copy link
Contributor Author

go.sum and go mod vendor updates?

Mentioned in slack, but a go mod tidy produces no changes.

davidby-influx
davidby-influx approved these changes Feb 28, 2023
View reviewed changes
Copy link

@davidby-influx davidby-influx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeffreyssmith2nd jeffreyssmith2nd merged commit a9dcfcf into master Feb 28, 2023
@jeffreyssmith2nd jeffreyssmith2nd deleted the smith/security branch February 28, 2023 20:44
@sranka sranka mentioned this pull request Feb 28, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidby-influx davidby-influx davidby-influx approved these changes

@jdstrand jdstrand jdstrand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeffreyssmith2nd @jdstrand @davidby-influx