Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove TableObject type assertion guards #4343

Closed
onelson opened this issue Dec 13, 2021 · 0 comments · Fixed by #4500
Closed

Remove TableObject type assertion guards #4343

onelson opened this issue Dec 13, 2021 · 0 comments · Fixed by #4500
Labels
team/query

Comments

@onelson
Copy link
Contributor

onelson commented Dec 13, 2021

This work will remove guards that check to see if a Value is a TableObject just before we make an attempt to invoke the Array.Len().

Once we after we are able to properly represent TableObjects separately from standard array objects, the type assertions should be redundant. At that point, hopefully both the compiler and humans will be able to tell the difference between these two types.
@onelson onelson mentioned this issue Dec 13, 2021
Closed
@onelson onelson mentioned this issue Dec 13, 2021
Merged
2 tasks
nathanielc added a commit that referenced this issue Feb 18, 2022
@nathanielc
fix(length): removes unnecessary TableObject guards
12db25c 
Now that the type system can distinguish between streams (aka tables)
and vanilla arrays we no longer need the TableObject interface and its
associated type guards.

Fixes #4343
@nathanielc nathanielc mentioned this issue Feb 18, 2022
Merged
2 tasks
nathanielc added a commit that referenced this issue Feb 18, 2022
@nathanielc
fix(length): removes unnecessary TableObject guards
e8b77cc 
Now that the type system can distinguish between streams (aka tables)
and vanilla arrays we no longer need the TableObject interface and its
associated type guards.

Fixes #4343
nathanielc added a commit that referenced this issue Feb 18, 2022
@nathanielc
fix(length): removes unnecessary TableObject guards (#4500)
4996f84 
Now that the type system can distinguish between streams (aka tables)
and vanilla arrays we no longer need the TableObject interface and its
associated type guards.

Fixes #4343
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
team/query
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(length): removes unnecessary TableObject guards influxdata/flux
1 participant
@onelson