-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update ragel version used by CI #1245
Conversation
@nathanielc I was able to build and test this new |
@wolffcm Yes, its a bit backwards, but the source of the image is the One way to solve would be to split this PR, one PR to change the docker image and one for the changes to the generated scanner. The docker image PR will go green, since it doesn't really change anything in CI. Then the second PR can be merged. The only catch is that no other PRs will go green until the changes to the scanner are merged. |
09984f6
to
f44a029
Compare
@nathanielc Ok, makes sense. I made this PR just update the dockerfile, and created a separate PR for updating the generated code: |
git \ | ||
make \ | ||
gcc \ | ||
libc-dev \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are gcc and libc-dev needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found that go vet
seems to use CGO, so it needs them. We wouldn't need them if we set CGO_ENABLED=0
in the environment. Do you have a preference?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a little more digging on this issue, I think that go vet
needs to build something for some reason, and through transitive dependencies something that needs CGO (I seem to recall that the net
package uses CGO) gets compiled.
This is a recent change in Go 1.11 that seems not to have been fixed in Go 1.12:
golang/go#26988
Maybe the best way forward would be to add CGO_ENABLED=0 to the environment, and if/when that Go bug gets fixed, we won't have any unneeded dependencies in the docker build.
f44a029
to
76bf82e
Compare
76bf82e
to
0273878
Compare
As it turns out, it's not possible to use I'll update the issue to reflect this, a different solution is needed. |
This was causing headaches because most users are using ragel 6.10 on
local machines, but the Docker image used 6.9 (several years old now).
Fixes #1183.
Done checklist