fix(runtime): move semantic analysis to the finalize step #2946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanielc
approved these changes
Jun 29, 2020
This moves the semantic analysis to the finalize step like it was previously. For applications that avoid finalizing unless they are using the interpreter, this should restore the quicker startup time because package registration will store the AST and move on. In the longer term, we probably want to stop using `init()` so much and switch to a system where the application explicitly pulls packages into the runtime. For now, this is more simple and doesn't involve any changes to existing applications and restores the previous speed for commands that do not use flux but import the flux runtime.
jsternberg
force-pushed
the
fix/startup-regression
branch
from
ef5c21c
to
6812212
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the semantic analysis to the finalize step like it was
previously. For applications that avoid finalizing unless they are using
the interpreter, this should restore the quicker startup time because
package registration will store the AST and move on.
In the longer term, we probably want to stop using
init()so much andswitch to a system where the application explicitly pulls packages into
the runtime. For now, this is more simple and doesn't involve any
changes to existing applications and restores the previous speed for
commands that do not use flux but import the flux runtime.
influxdata/influxdb#18292
Done checklist