feat: rework CI pipeline to support C# 12, .NET 8.0 and tests on .NET Framework 4.8 #613
Conversation
…d align .csproj file
… in the same folder as ExampleBlazor
… example projects
…t .NET SDK The .NET solution is now built and packed with a .NET 8 SDK Docker image and the resulting build is copied for testing with .NET Core 3.1/5/6/7/8 and for deployment. Install InfluxDB 2.x to perform all tests on Windows (only Client.Legacy was tested). Simplify some steps.
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #613 +/- ##
==========================================
+ Coverage 87.13% 89.26% +2.12%
==========================================
Files 77 47 -30
Lines 6893 2123 -4770
Branches 0 311 +311
==========================================
- Hits 6006 1895 -4111
+ Misses 887 176 -711
- Partials 0 52 +52 ☔ View full report in Codecov by Sentry. |
| - dotnet-6.0 | ||
| - dotnet-7.0 | ||
| - dotnet-windows | ||
| # - check-code-formatting # TODO: uncomment |
There was a problem hiding this comment.
Code formatting check is currently commented as many new C# features (introduced after C# 8) are applied by ReSharper (eg. file scoped namespaces, target-typed new expressions).
I see two options:
- A big commit that reformats all files,
- Override some unnecessary formatting rules (like file scoped namespaces).
There was a problem hiding this comment.
We can leave it commented out for now and, after merging this PR, create another one to address the formatting issues. Does this approach work for you?
| key: *cache-key | ||
| paths: | ||
| - ./ReSharperCLI | ||
|
|
||
| deploy-preview: |
There was a problem hiding this comment.
How do you deploy production NuGet packages (those without -dev.CIRCLE_BUILD_NUM)?
We can probably integrate this deployment phase in this pipeline with a manual approval.
There was a problem hiding this comment.
We don't want to deploy production packages by CI.
There was a problem hiding this comment.
Ok, that's a shame because it would keep track of build and test logs, and would also guarantee that all tests are carried out on the exact same assemblies deployed in production...
Sylvain2703
changed the title
… to other README files
| dotnet nuget push ./NuGetPackages/InfluxDB.Client.*.nupkg -s ${BONITOO_NUGET_URL} -k ${BONITOO_SNAPSHOT_APIKEY} -sk ${BONITOO_SNAPSHOT_APIKEY} |
There was a problem hiding this comment.
Please ensure to include dev.$CIRCLE_BUILD_NUM. as part of the regex. This is crucial to guarantee that only the packages generated in the current CI run are pushed.
| dotnet nuget push ./NuGetPackages/InfluxDB.Client.*.nupkg -s ${BONITOO_NUGET_URL} -k ${BONITOO_SNAPSHOT_APIKEY} -sk ${BONITOO_SNAPSHOT_APIKEY} | |
| dotnet nuget push ./NuGetPackages/InfluxDB.Client.*-dev.$CIRCLE_BUILD_NUM.nupkg -s ${BONITOO_NUGET_URL} -k ${BONITOO_SNAPSHOT_APIKEY} -sk ${BONITOO_SNAPSHOT_APIKEY} |
|
This PR has been closed because it has not had recent activity. Please reopen if this PR is still important to you and you want to continue with them. |
Proposed Changes
Features
Tests
Build
Checklist
dotnet testcompletes successfully