Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: parsing date fails due to thread race #477

Merged
merged 1 commit into from
Aug 8, 2022
Merged

fix: parsing date fails due to thread race #477

merged 1 commit into from
Aug 8, 2022

Conversation

rdinoff
Copy link
Contributor

@rdinoff rdinoff commented Jul 29, 2022 •
edited
Loading

Closes #471

Proposed Changes

Two python threads can call get_date_helper() simultaneously, causing a
partially-contstructed DateHelper object to be returned to the caller.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • pytest tests completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@bednar bednar self-requested a review August 1, 2022 05:25
bednar
bednar requested changes Aug 1, 2022
View reviewed changes
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rdinoff thanks for your PR 👍. It is an awesome fix 💯

Can you please satisfy our checklist before we accept this PR:

image

and also there is a following requirement:

influxdb_client/client/util/date_utils.py Outdated Show resolved Hide resolved
fix: parsing date fails due to thread race
064f31c 
Two python threads can call get_date_helper() simultaneously, causing a
partially-contstructed DateHelper object to be returned to the caller.
powersj
powersj approved these changes Aug 5, 2022
View reviewed changes
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR!

@powersj powersj requested a review from bednar August 5, 2022 16:50
bednar
bednar approved these changes Aug 8, 2022
View reviewed changes
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rdinoff thanks again for your PR 👍

@bednar bednar merged commit 39dcc1f into influxdata:master Aug 8, 2022
@bednar bednar added this to the 1.32.0 milestone Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bednar bednar bednar approved these changes

@powersj powersj powersj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.32.0
Development

Successfully merging this pull request may close these issues.

FluxRecord returns '_start': None, '_stop': None, '_time': None
3 participants
@rdinoff @bednar @powersj