fix: prevent exceptions in callbacks from causing deadlocks #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is one part of a fix for influxdata#558 It: * Adds a WriteOption `max_close_wait` (default 500,000ms) * Adjust `__del__` so that we'll only wait `max_close_wait`ms for queued writes to complete * Adds a warning if the threshold is hit
The other part of the fix for influxdata#558 If a configured callback results in an exception we'll trap it and log the details rather than allowing it to interrupt the parent thread
This introduces a new testing dependency: `pytest-timeout`. As the issue being tested for can cause deadlocks, it seemed prudent to avoid tests locking up
powersj
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #558
Proposed Changes
Introduces two levels of deadlock protection
close()The second change involves the introduction of a new WriteOption:
max_close_wait. The default is set to 5 minutes, but can be overriden in the same manner as other write options.Note: in order to allow the failure to be tested safely,
pytest-timeouthas been added as a test dependency.Checklist
pytest testscompletes successfully