Add template variable subpage UI #11810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlirieGray
force-pushed
the
feat/temp-vars-tab
branch
from
bf335fe
to
00fd68c
Compare
OfTheDelmer
approved these changes
Feb 12, 2019
| } | ||
|
|
||
| private handleChangeInput = (e: ChangeEvent<HTMLInputElement>) => { | ||
| const value = e.target.value |
There was a problem hiding this comment.
Suggested change
| const value = e.target.value | |
| const {value, name} = e.target | |
| this.setState({[name]: value}) |
| } | ||
|
|
||
| private handleCreateVariable = () => { | ||
| const {onCloseModal} = this.props |
There was a problem hiding this comment.
Suggested change
| const {onCloseModal} = this.props | |
| this.props.onCloseModal() |
| script={script} | ||
| onChangeScript={this.handleChangeScript} | ||
| visibility="visible" | ||
| status={{text: '', type: ''}} |
There was a problem hiding this comment.
Maybe there could be some kind default status prop in the FluxEditor so we don't have to specify this when we're not updating it
| <OverlayContainer maxWidth={1000}> | ||
| <OverlayHeading | ||
| title="Create Variable" | ||
| onDismiss={this.props.onCloseModal} |
There was a problem hiding this comment.
Suggested change
| onDismiss={this.props.onCloseModal} | |
| onDismiss={onCloseModal} |
| overlayState: OverlayState | ||
| } | ||
|
|
||
| export default class Buckets extends PureComponent<Props, State> { |
There was a problem hiding this comment.
Suggested change
| export default class Buckets extends PureComponent<Props, State> { | |
| export default class Variables extends PureComponent<Props, State> { |
|
|
||
| export { | ||
| TemplateType, | ||
| TemplateValue, | ||
| TemplateValueType, | ||
| Template, | ||
| OverlayState, |
AlirieGray
force-pushed
the
feat/temp-vars-tab
branch
3 times, most recently
from
e854c0e
to
31b3ab5
Compare
AlirieGray
changed the title
AlirieGray
force-pushed
the
feat/temp-vars-tab
branch
4 times, most recently
from
99781fe
to
08a88de
Compare
AlirieGray
force-pushed
the
feat/temp-vars-tab
branch
from
08a88de
to
d3d1fef
Compare
mgattozzi
added a commit
that referenced
this pull request
Sep 5, 2024
This syncs OSS to pro and fixes the cargo-deny errors in CI. This uses the exact same config as IOx from #11810. influxdata/influxdb_iox#11810
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: https://github.com/influxdata/applications-team-issues/issues/284
This PR adds a subpage to the /organizations page for template variables. The page includes a button that opens an overlay to create a new template variable. However, this UI is not currently connected to the backend.
In addition, some types are moved out of the /v2 folder to the /types folder.