fix(ui): add ordering to org resources #11938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebb-tide
approved these changes
Feb 15, 2019
| @@ -196,6 +204,7 @@ class OrganizationView extends PureComponent<Props> { | |||
| <GetOrgResources<Variable[]> | |||
| organization={org} | |||
| fetcher={getVariables} | |||
| orderBy={{keys: ['name']}} | |||
There was a problem hiding this comment.
should orderBy be an optional prop with default= {keys:['name]}
There was a problem hiding this comment.
@ebb-tide I was wondering that after most places it was used benefited from a simple name ordering. It should just ignore ordering if the collection doesn't have that key. Hmm would it be worth typing the orderedBy.keys property names of the collection item?
OfTheDelmer
force-pushed
the
fix/11891
branch
from
c733dd3
to
564f858
Compare
OfTheDelmer
force-pushed
the
fix/11891
branch
from
564f858
to
a501b4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11891
Briefly describe your proposed changes:
Adds ordering to labels and org resources