Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge point parse & explode #12377

Merged
merged 1 commit into from
Apr 24, 2019
Merged

Merge point parse & explode #12377

merged 1 commit into from
Apr 24, 2019

Conversation

benbjohnson
Copy link
Contributor

No description provided.

@benbjohnson benbjohnson self-assigned this Mar 5, 2019
@benbjohnson benbjohnson force-pushed the explode branch 2 times, most recently from 9a30166 to 17e2501 Compare March 6, 2019 18:30
@benbjohnson benbjohnson requested a review from e-dard March 6, 2019 18:57
@benbjohnson benbjohnson marked this pull request as ready for review March 6, 2019 18:57
@benbjohnson
Copy link
Contributor Author

Needs to rebase after #12391 is merged.

@e-dard
Copy link
Contributor

e-dard commented Apr 3, 2019

Did this get closed and opened again? I thought there was already a bunch of review done?

@benbjohnson
Copy link
Contributor Author

@e-dard Previous discussion here: #11617

I rebased and updated this PR.

Copy link
Contributor

@e-dard e-dard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of questions

@@ -18,8 +18,7 @@ import (
"github.com/influxdata/influxdb/pkg/escape"
)

// Values used to store the field key and measurement name as special internal
// tags.
// Values used to store the field key and measurement name as special internal tags.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

models/points.go Show resolved Hide resolved
models/points.go Outdated Show resolved Hide resolved
models/points.go Outdated Show resolved Hide resolved
@benbjohnson benbjohnson force-pushed the explode branch 8 times, most recently from 86c2b05 to 1794508 Compare April 24, 2019 15:47
Copy link
Contributor

@e-dard e-dard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 This PR in another guidse previously had multiple reviews.

@benbjohnson benbjohnson merged commit 01bfcf8 into master Apr 24, 2019
@benbjohnson benbjohnson deleted the explode branch April 24, 2019 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants