-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge point parse & explode #12377
Merge point parse & explode #12377
Conversation
9a30166
to
17e2501
Compare
Needs to rebase after #12391 is merged. |
33b22bc
to
8f21989
Compare
Did this get closed and opened again? I thought there was already a bunch of review done? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of questions
@@ -18,8 +18,7 @@ import ( | |||
"github.com/influxdata/influxdb/pkg/escape" | |||
) | |||
|
|||
// Values used to store the field key and measurement name as special internal | |||
// tags. | |||
// Values used to store the field key and measurement name as special internal tags. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
86c2b05
to
1794508
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 This PR in another guidse previously had multiple reviews.
No description provided.