feat(variables): add ability to add a variable to script from side menu #12706
Conversation
AlirieGray
force-pushed
the
feat(variables)/add-to-script-from-side-menu
branch
from
7bd05fd
to
c49fcb2
Compare
| @@ -29,7 +33,14 @@ const VariableItem: FunctionComponent<Props> = ({variable}) => { | |||
| onMouseLeave={() => setTooltipVisible(false)} | |||
| ref={trigger} | |||
| > | |||
| <div className="variables-toolbar--label">{variable.name}</div> | |||
| <div | |||
There was a problem hiding this comment.
could you make this its own component?
| const back = lineToEdit.slice(characterNumber, lineToEdit.length) | ||
|
|
||
| const updatedLine = `${front}v.${variableName}${back}` | ||
| const script = scriptLines |
There was a problem hiding this comment.
i dont think this line is necessary
| const front = lineToEdit.slice(0, characterNumber) | ||
| const back = lineToEdit.slice(characterNumber, lineToEdit.length) | ||
|
|
||
| const updatedLine = `${front}v.${variableName}${back}` |
There was a problem hiding this comment.
could there be a function that takes the variable name and returns the namespaced variable as v.${varName}? This could then be used on line 134 to get the length to increase the ch by rather than the hardcoded 2 right now.
|
|
||
| const updatedCursorPosition = { | ||
| line: currentLineNumber, | ||
| ch: currentCharacterNumber + variableName.length + 2, |
There was a problem hiding this comment.
this variableName.length + 2 seems like an arbitrary 2 which could possibly change. i have another comment about a potential solution to this.
| variableName | ||
| ) | ||
|
|
||
| const updatedCursorPosition = { |
There was a problem hiding this comment.
how do you feel about making a function for getting the cursor position? if the naming is a problem since theres already updateCursorPosition, there could potentially just be 2 files, one for inserting variables and one for inserting functions
AlirieGray
force-pushed
the
feat(variables)/add-to-script-from-side-menu
branch
2 times, most recently
from
09f63bf
to
ef696a8
Compare
AlirieGray
force-pushed
the
feat(variables)/add-to-script-from-side-menu
branch
from
ef696a8
to
e8ffda2
Compare
Closes #11699
This PR introduces the ability to add a variable to a script in the DE or VEO by clicking on a variable in the side menu of the script editor. This variable will be added where the user's cursor is located.