Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Go client library and benchmarks. #1349

Merged
merged 19 commits into from
Jan 27, 2015
Merged

New Go client library and benchmarks. #1349

merged 19 commits into from
Jan 27, 2015

Conversation

corylanou
Copy link
Contributor

All WIP, nothing to see here.

@corylanou
Copy link
Contributor Author

@otoolep this is the first "phase" of the new cli and client library. There will be more work to come, but basic functionality here is already useful. I suggest closing this so people can see where we are headed and I will pick it back up in a future PR. Thoughts?

@otoolep
Copy link
Contributor

otoolep commented Jan 26, 2015

But not merging, correct?

@corylanou
Copy link
Contributor Author

@otoolep I am suggesting merging this. Currently, the client library and cli are completely broken and useless. This brings up a baseline cli, and baseline client library. While we are going to be adding more functionality later, what we have here is already useful.

@otoolep
Copy link
Contributor

otoolep commented Jan 27, 2015

Fine with me, since the current CLI is of very little value due to the API change, I don't think we're losing anything.

corylanou added a commit that referenced this pull request Jan 27, 2015
New Go client library and benchmarks.
@corylanou corylanou merged commit 2432d6b into master Jan 27, 2015
@corylanou corylanou deleted the client-refactoring branch January 27, 2015 00:16
mark-rushakoff pushed a commit that referenced this pull request Jan 11, 2019
Add end-to-end write/query integration testing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants