Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui/buckets): add buckets danger zone #13520

Merged
merged 1 commit into from
Apr 19, 2019
Merged

feat(ui/buckets): add buckets danger zone #13520

merged 1 commit into from
Apr 19, 2019

Conversation

OfTheDelmer
Copy link
Contributor

@OfTheDelmer OfTheDelmer commented Apr 19, 2019 •
edited by ischolten
Loading

Closes #13494

Briefly describe your proposed changes:
Adds a danger zone warning users about the perils of editing a bucket name.

Screen Shot 2019-04-19 at 4 11 22 PM

Screen Shot 2019-04-19 at 4 12 43 PM

Screen Shot 2019-04-19 at 4 13 28 PM

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Sign CLA (if not already signed)

@OfTheDelmer @ischolten
feat(ui/buckets): add buckets danger zone
4684b9f 
Co-authored-by: Iris Scholten <ischolten.is@gmail.com>
@ischolten ischolten merged commit a7e7f20 into master Apr 19, 2019
@ischolten ischolten deleted the bucket-danger-zone branch April 19, 2019 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bthesorceror bthesorceror bthesorceror approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Editing a bucket name should warn user of implications
3 participants
@OfTheDelmer @bthesorceror @ischolten