fix(tasks): add run limit check to analytical store #14569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlirieGray
force-pushed
the
tasks/fix-run-limit-api
branch
4 times, most recently
from
19931bf
to
7c593d5
Compare
ghost
requested review from
docmerlin
suggested changes
Aug 5, 2019
AlirieGray
force-pushed
the
tasks/fix-run-limit-api
branch
from
7c593d5
to
62cb7ff
Compare
docmerlin
approved these changes
Aug 6, 2019
AlirieGray
force-pushed
the
tasks/fix-run-limit-api
branch
2 times, most recently
from
72bec9c
to
d6ca271
Compare
AlirieGray
force-pushed
the
tasks/fix-run-limit-api
branch
from
d6ca271
to
ca6625c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13575
This PR fixes an issue where setting a limit in the query for getting runs for a task did not work, and would instead return all runs for the task. A limit was added to the flux function retrieving the runs, and the length of the runs was checking before adding to the runs to be returned.