Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ui): alerting details polish #15056

Merged
merged 9 commits into from
Sep 9, 2019
Merged

refactor(ui): alerting details polish #15056

merged 9 commits into from
Sep 9, 2019

Conversation

alexpaxton
Copy link
Contributor

@alexpaxton alexpaxton commented Sep 9, 2019 •
edited
Loading

Closes #14946
Closes #15036
Closes #14804
Closes #15057

Screen Shot 2019-09-09 at 9 33 35 AM
threshold-2-places
system-buckets
bucket-name-validation

System buckets removed from generate token overlay:
Screen Shot 2019-09-09 at 11 24 17 AM

No system buckets in dropdown during scraper / telegraf config creation:
Screen Shot 2019-09-09 at 11 27 57 AM
Screen Shot 2019-09-09 at 11 28 04 AM

No system buckets in save as task form
Screen Shot 2019-09-09 at 11 31 01 AM

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Documentation updated or issue created (provide link to issue/pr)
  • Signed CLA (if not already signed)

@alexpaxton alexpaxton changed the title refactor(ui): alerting details pollish refactor(ui): alerting details polish Sep 9, 2019
russorat
russorat approved these changes Sep 9, 2019
View reviewed changes
Copy link
Contributor

@russorat russorat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ this!

@alexpaxton alexpaxton merged commit 32d1120 into master Sep 9, 2019
@alexpaxton alexpaxton deleted the refactor/alerting-tweaks branch September 9, 2019 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@russorat russorat russorat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@alexpaxton @russorat