fix(ui/labeloverlayerror): invalid input error resolved #15443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UI is now correctly disabling the submit button and returning an invalid input error when a user tries to submit an empty input for the label overlay name
ghost
requested review from
Updated the updateLabelOverlay methods to correspond with the changes made to the labeloverlayform
desa
force-pushed
the
fix/overlay-empty-fields
branch
from
ca0c82f
to
38db8a3
Compare
asalem1
changed the title
121watts
approved these changes
Oct 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13940
UI is now correctly disabling the submit button and returning an invalid input error when a user tries to submit an empty input for the label overlay name
Problem
Label Overlay UI was allowing an empty string to be submitted as a name
Solution
Modified the name validation function to render an error message & disable the submit button when a user tries to submit an overlay label name that is empty
Describe your proposed changes here.