fix(http): update swagger for easily use in clients #16067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bednar
commented
Dec 2, 2019
bednar
commented
- added date-time format for start and stop DeletePredicateRequest
- fixed malformed reference to ViewProperties in PkgChart model
- define separate model for RetentionRule as is in Organizations, Buckets, Labels
- "labels" property from Check and PostCheck should be part of CheckBase (it is ancestor for all Check types)
- "labels" property from NotificationRule and PostNotificationRule should be part of NotificationRuleBase (it is ancestor for all NotificationRule and types)
- "labels" property from NotificationEndpoint and PostNotificationEndpoint should be part of NotificationEndpointBase (it is ancestor for all NotificationEndpoint and types)
- The url property of HTTPNotificationRuleBase should not be required
- Added query link for CheckBase and NotificationRuleBase
- Well-formatted commit messages
- Rebased/mergeable
- Tests pass
- http/swagger.yml updated (if modified Go structs or API)
- Signed CLA (if not already signed)
* added date-time format for start and stop DeletePredicateRequest * fixed malformed reference to ViewProperties in PkgChart model * define separate model for RetentionRule as is in Organizations, Buckets, Labels * "labels" property from Check and PostCheck should be part of CheckBase (it is ancestor for all Check types) * "labels" property from NotificationRule and PostNotificationRule should be part of NotificationRuleBase (it is ancestor for all NotificationRule and types) * "labels" property from NotificationEndpoint and PostNotificationEndpoint should be part of NotificationEndpointBase (it is ancestor for all NotificationEndpoint and types) * The url property of HTTPNotificationRuleBase should not be required * Added query link for CheckBase and NotificationRuleBase
kelwang
approved these changes
Dec 2, 2019
alexpaxton
pushed a commit
that referenced
this pull request
Jan 9, 2020
* added date-time format for start and stop DeletePredicateRequest * fixed malformed reference to ViewProperties in PkgChart model * define separate model for RetentionRule as is in Organizations, Buckets, Labels * "labels" property from Check and PostCheck should be part of CheckBase (it is ancestor for all Check types) * "labels" property from NotificationRule and PostNotificationRule should be part of NotificationRuleBase (it is ancestor for all NotificationRule and types) * "labels" property from NotificationEndpoint and PostNotificationEndpoint should be part of NotificationEndpointBase (it is ancestor for all NotificationEndpoint and types) * The url property of HTTPNotificationRuleBase should not be required * Added query link for CheckBase and NotificationRuleBase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.