Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pkger): add check dry functionality #16262

Merged
merged 1 commit into from
Dec 18, 2019
Merged

feat(pkger): add check dry functionality #16262

merged 1 commit into from
Dec 18, 2019
+275 −29

Conversation

jsteenb2
Copy link
Contributor

@jsteenb2 jsteenb2 commented Dec 18, 2019 •
edited
Loading

@jsteenb2 jsteenb2 requested review from a team as code owners December 18, 2019 07:10
@jsteenb2 jsteenb2 requested review from a team and removed request for a team December 18, 2019 07:13
@jsteenb2 jsteenb2 force-pushed the 4966p/pkger_checks_dry_run branch 8 times, most recently from ba28844 to 0af6f26 Compare December 18, 2019 17:34
imogenkinsman
imogenkinsman reviewed Dec 18, 2019
View reviewed changes
http/middleware.go
"go.uber.org/zap"
)

// Middleware constructor.
type Middleware func(http.Handler) http.Handler

func traceMW(next http.Handler) http.Handler {
Copy link
Contributor

@imogenkinsman imogenkinsman Dec 18, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome - I know you're just moving it in this PR, but glad we've abstracted this into a wrapper like this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay for adding orthogonal functionality without editing specific call sites 🍔 . This was introduced during initial pkger http server

@jsteenb2
Copy link
Contributor Author

ughhh same backend executor flaky tests again.... really need to get thsi fixed, wasting a lot of CI cycles on it

@jsteenb2 jsteenb2 merged commit 1db3256 into master Dec 18, 2019
@jsteenb2 jsteenb2 deleted the 4966p/pkger_checks_dry_run branch December 18, 2019 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imogenkinsman imogenkinsman imogenkinsman approved these changes

@dearyhud dearyhud dearyhud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsteenb2 @imogenkinsman @dearyhud