Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): fixed flakey tests #16268

Merged
merged 3 commits into from
Dec 18, 2019
Merged

fix(ui): fixed flakey tests #16268

merged 3 commits into from
Dec 18, 2019

Conversation

asalem1
Copy link
Contributor

@asalem1 asalem1 commented Dec 18, 2019

Closes #16253

Problem

flush & signin would flake if called multiple times in the same test suite

Solution

consolidated the logic that needed to be retrieved from signing in into the first beforeEach call and removed the multiple usages of cy.flush and cy.signin since the test suite was logging in successfully and was flaking when we would flush the credentials and sign in again due to idiosyncrasies in the way the tests were running

  • CHANGELOG.md updated with a link to the PR (not the Issue)

@asalem1 asalem1 requested a review from a team December 18, 2019 15:51
@ghost ghost requested review from desa and drdelambre and removed request for a team December 18, 2019 15:51
@drdelambre
Copy link
Contributor

so it was already logged in, then broke itself trying to login again?

@asalem1
Copy link
Contributor Author

asalem1 commented Dec 18, 2019

so it was already logged in, then broke itself trying to login again?

Something like that. We were also flushing the credentials so if the operation hadn't stopped running, we would all of a sudden lose context and not have specific properties that may have been available at the outset of the test

Copy link
Contributor

@drdelambre drdelambre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if anything, its simpler and easier to reason about

@asalem1 asalem1 merged commit 63b8129 into master Dec 18, 2019
@asalem1 asalem1 deleted the signin-flakiness branch December 18, 2019 22:07
alexpaxton pushed a commit that referenced this pull request Jan 9, 2020
fix(ui): fixed flakey tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

General Sigin/Setup flakiness
2 participants