feat(kit/check): Manual Overrides for Readiness Endpoint #16336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettbuddin
changed the title
ghost
requested review from
brettbuddin
force-pushed
the
ready-manual-override
branch
from
71a2806
to
74b00db
Compare
lyondhill
approved these changes
Dec 27, 2019
gitirabassi
approved these changes
Dec 30, 2019
…int.
With `/health`, it is possible to override the overall status reported.
This change adds the same functionality to `/ready`. This allows
incident responders to take an unhealthy pod out of a service without
killing it—giving them time to gather meaningful forensic data from the
pod. The new contract is:
Force not ready:
GET /ready?force=true&ready=false
Force ready:
GET /ready?force=true&ready=true
Disable override:
GET /ready?force=false
brettbuddin
force-pushed
the
ready-manual-override
branch
from
879c462
to
c42a232
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
/health, it is possible to override the overall status reported. This change adds the same functionality to/ready. This allows incident responders to take an unhealthy pod out of a service without killing it—giving them time to gather meaningful forensic data from the pod. The new contract is:Force not ready:
Force ready:
Disable override: