fix: enable skipped tests for notification rules and fixup issue in tag matcher #16380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsteenb2
force-pushed
the
fix/notification_rule_tag_match
branch
from
a59757c
to
62c75ce
Compare
jsteenb2
force-pushed
the
fix/notification_rule_tag_match
branch
from
62c75ce
to
2405928
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some awkward looping made it hard to reason about the correctness of the tag matching algorithm. Upon closer inspection of a test through the debugger, it was returning false negatives and was causing issues in the
FindNotificiationRulescall.seeing issues with this upstream, these tests can be enabled. The issue was in tag matcher. Tests pass here and should pass upstream now.
solves for the failures here: #16379
Closes #14799