Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pkger): make pkger packages CRD compliant #16523

Merged
merged 1 commit into from
Jan 14, 2020
Merged

feat(pkger): make pkger packages CRD compliant #16523

merged 1 commit into from
Jan 14, 2020

Conversation

jsteenb2
Copy link
Contributor

@jsteenb2 jsteenb2 commented Jan 13, 2020 •
edited

Closes #16501

Makes packages compliant with k8s CRDs. More detail in the issue linked above.

Recommend viewing the PR from this link (with only .go files showing): https://github.com/influxdata/influxdb/pull/16523/files?file-filters%5B%5D=.go

@jsteenb2 jsteenb2 force-pushed the 16501/crd_the_packages branch 3 times, most recently from 7bb25eb to ccf1bb9 Compare January 14, 2020 02:07
@jsteenb2 jsteenb2 requested a review from a team January 14, 2020 02:07
@jsteenb2 jsteenb2 requested review from a team as code owners January 14, 2020 02:14
@jsteenb2 jsteenb2 removed request for a team January 14, 2020 02:14
@jsteenb2 jsteenb2 force-pushed the 16501/crd_the_packages branch 3 times, most recently from 276b5bb to 5fecdc6 Compare January 14, 2020 16:34
kelwang
kelwang reviewed Jan 14, 2020
View reviewed changes
pkger/parser.go Outdated Show resolved Hide resolved
kelwang
kelwang suggested changes Jan 14, 2020
View reviewed changes
Copy link
Contributor

@kelwang kelwang left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't read the crd specs, beside the Kind type naming, most looks good

@jsteenb2 jsteenb2 force-pushed the 16501/crd_the_packages branch 2 times, most recently from 5be1aad to b29e423 Compare January 14, 2020 20:17
@jsteenb2 jsteenb2 merged commit 63fd1e2 into master Jan 14, 2020
@jsteenb2 jsteenb2 deleted the 16501/crd_the_packages branch January 14, 2020 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelwang kelwang kelwang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pkger should be compatible with a Kubernetes Object
2 participants
@jsteenb2 @kelwang