Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): updated trigger to be onFocus as well as onChange #17161

Merged
merged 2 commits into from
Mar 10, 2020

Conversation

asalem1
Copy link
Contributor

@asalem1 asalem1 commented Mar 9, 2020

Closes #16277

Problem

The default option for customizing a table's values would not be updated even when the input was selected.

Solution

Added an onFocus listener to trim values based on the custom input field

decimal_bug

  • CHANGELOG.md updated with a link to the PR (not the Issue)

@asalem1 asalem1 requested review from a team and 121watts and removed request for a team March 9, 2020 21:41
@asalem1 asalem1 requested review from drdelambre and removed request for 121watts March 10, 2020 12:42
@asalem1 asalem1 merged commit 952e31f into master Mar 10, 2020
@asalem1 asalem1 deleted the fix/table-decimal branch March 10, 2020 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decimal Places table option does not work
2 participants