Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cmd/influx): add --file option to query and task commands #17595

Merged
merged 6 commits into from
Apr 8, 2020

Conversation

sranka
Copy link
Contributor

@sranka sranka commented Apr 3, 2020

Closes #17356

Describe your proposed changes here.

  • influx query, influx task create and influx task update now support a new --file (-f) option

  • flux is read from stdin when no argument or file is supplied

  • backward compatibility: '@/path/to/flux' or '-' arguments are still supported

  • CHANGELOG.md updated with a link to the PR (not the Issue)

  • Well-formatted commit messages

  • Rebased/mergeable

  • Tests pass

  • http/swagger.yml updated (if modified Go structs or API)

  • Documentation updated or issue created (provide link to issue/pr)

  • Signed CLA (if not already signed)

@sranka
Copy link
Contributor Author

sranka commented Apr 3, 2020

@sanderson can you pls review/proofread help messages

@sranka sranka requested a review from kelwang April 3, 2020 06:15
@sranka sranka changed the title feat(cmd/influx): add -f option to query, and task commands feat(cmd/influx): add -f option to query and task commands Apr 3, 2020
@sranka sranka changed the title feat(cmd/influx): add -f option to query and task commands feat(cmd/influx): add --file option to query and task commands Apr 3, 2020
Copy link
Contributor

@sanderson sanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor copy suggestions. Looks good!

cmd/influx/query.go Outdated Show resolved Hide resolved
cmd/influx/query.go Outdated Show resolved Hide resolved
cmd/influx/task.go Outdated Show resolved Hide resolved
cmd/influx/task.go Outdated Show resolved Hide resolved
cmd/influx/task.go Outdated Show resolved Hide resolved
cmd/influx/task.go Outdated Show resolved Hide resolved
@sranka sranka merged commit 179adb0 into master Apr 8, 2020
@sranka sranka deleted the 17356/influx-cli-file branch April 8, 2020 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove required '@' prefix for file paths in 'influx' CLI
2 participants