fix(ui): fixed dark lines in checks #17651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drdelambre
approved these changes
Apr 7, 2020
asalem1
force-pushed
the
fix/checks-dark-color
branch
from
8434925
to
9c1ac61
Compare
drdelambre
approved these changes
Apr 7, 2020
TCL735
approved these changes
Apr 7, 2020
…s and removed unused components
asalem1
commented
Apr 7, 2020
| import React, {FC} from 'react' | ||
| import {connect} from 'react-redux' | ||
| import {Form, Grid} from '@influxdata/clockface' | ||
|
|
There was a problem hiding this comment.
Since the CheckPlot is only ever used in alerting in the VEO, there is no option to select CheckOptions
| @@ -44,8 +43,6 @@ class OptionsSwitcher extends PureComponent<Props> { | |||
| return <HeatmapOptions {...view.properties} /> | |||
| case 'scatter': | |||
| return <ScatterOptions {...view.properties} /> | |||
| case 'check': | |||
There was a problem hiding this comment.
CheckOptions is unused
| @@ -308,7 +308,7 @@ const NEW_VIEW_CREATORS = { | |||
| }, | |||
| }, | |||
| ], | |||
| colors: NINETEEN_EIGHTY_FOUR, | |||
There was a problem hiding this comment.
Switching over to a different default allows for a consistent color schema for the CheckViewProperties. This ensures that both the view history and default view are the same type
TCL735
approved these changes
Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16923
Problem
CheckPlot line and font colors were not being mapped correctly onto the canvas
Solution
Updated the swagger.yml to accurately reflect the color struct (from an array of strings to an array of DashboardColors). Added mapping logic to isolate the colors in an array so that the colors could be set accurately and added the default options.