fix(kv): don't set session expiration time to earlier than existing expiration on renew session #17751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeorgeMac
requested review from
a team and
gavincabbage
and removed request for
a team
GeorgeMac
changed the title
gianarb
approved these changes
Apr 15, 2020
GeorgeMac
force-pushed
the
gm/session-renewal
branch
from
98b6d3b
to
545ace2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17750
This change ensures the current expiration time on a session is respected and retained until a new expiration time is presented which extends the life of the session.
Until this change, a session could be shortened via
RenewSession.This was happening frequently within the
http.AuthenticationMiddleware. Rendering all sessions around 5 minutes long.