Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dbrpv2): lookup by org name #18331

Merged
merged 1 commit into from
Jun 2, 2020
Merged

fix(dbrpv2): lookup by org name #18331

merged 1 commit into from
Jun 2, 2020

Conversation

gavincabbage
Copy link
Contributor

@gavincabbage gavincabbage commented Jun 2, 2020

This change adds support for the org name parameter in addition to orgID for organization lookup when interacting with the DBRP HTTP APIs for reading, updating and deleting DBRP mappings. It also enhances the DBRP mapping creation operation to consider organization in the request body, if organization_id is missing

The logic is enhanced to fallback to look up the org ID from the org name if the ID is not present. If both are provided, the name will be ignored in favor of the ID.

@gavincabbage gavincabbage requested a review from a team as a code owner June 2, 2020 13:30
@gavincabbage gavincabbage requested review from hoorayimhelping and removed request for a team June 2, 2020 13:30
@hoorayimhelping
Copy link
Contributor

what does DBRP stand for?

@gavincabbage
Copy link
Contributor Author

@hoorayimhelping "DBRP Mappings" map 1.x database/retention policy pairs to 2.x buckets. This concept was added to support InfluxQL on Cloud 2.

Copy link
Contributor

@stuartcarnie stuartcarnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid work and ❤️ the expansion of tests

@gavincabbage gavincabbage merged commit f159b86 into master Jun 2, 2020
@gavincabbage gavincabbage deleted the fix/dbrp/find-by-org branch June 2, 2020 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants