Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(influx): have delete cmd respect the config settings #18345

Merged
merged 1 commit into from
Jun 2, 2020
Merged

fix(influx): have delete cmd respect the config settings #18345

merged 1 commit into from
Jun 2, 2020

Conversation

jsteenb2
Copy link
Contributor

@jsteenb2 jsteenb2 commented Jun 2, 2020 •
edited
Loading

Closes #17289

@jsteenb2 jsteenb2 force-pushed the 17289/influx_delete_cmd_disrespecting_config branch from 899b216 to 42391aa Compare June 2, 2020 23:07
@jsteenb2 jsteenb2 force-pushed the 17289/influx_delete_cmd_disrespecting_config branch from 42391aa to 99bcc42 Compare June 2, 2020 23:08
hoorayimhelping
hoorayimhelping approved these changes Jun 2, 2020
View reviewed changes
Copy link
Contributor

@hoorayimhelping hoorayimhelping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you ever feel like *cobra.Command should be *cobra.Commander ?

dcy44sv-034d3b57-89da-4d61-8526-57f1f6668eaf

@jsteenb2 jsteenb2 force-pushed the 17289/influx_delete_cmd_disrespecting_config branch from 99bcc42 to 1a656c5 Compare June 2, 2020 23:12
@jsteenb2 jsteenb2 merged commit d21fce5 into master Jun 2, 2020
@jsteenb2 jsteenb2 deleted the 17289/influx_delete_cmd_disrespecting_config branch June 2, 2020 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoorayimhelping hoorayimhelping hoorayimhelping approved these changes

@russorat russorat Awaiting requested review from russorat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

influx cli delete command still requires org even with profiles
2 participants
@jsteenb2 @hoorayimhelping