fix(influx): validate host urls for influx config commands #18707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this deprecates the old flags, but they are still accessible if using them explictly. They are hidden from the -h message. When used the CLI prints out a message indicating the flag is deprecated and to use the new flag instead.
jsteenb2
force-pushed
the
18706/influx_config_host_parse
branch
from
ccd406a
to
e44e739
Compare
jsteenb2
commented
Jun 24, 2020
| // the short flags will still be respected but their long form is different. | ||
| cmd.Flags().StringVar(&b.name, "name", "", "The config name (required)") | ||
| cmd.Flags().MarkDeprecated("name", "use the --config-name flag") | ||
| cmd.Flags().StringVar(&b.url, "url", "", "The host url (required)") |
There was a problem hiding this comment.
@sanderson these are the flags that are being deprecated. They still work, but won't show up in the -h anymore
sanderson
approved these changes
Jun 24, 2020
| // the short flags will still be respected but their long form is different. | ||
| cmd.Flags().StringVar(&b.name, "name", "", "The config name (required)") | ||
| cmd.Flags().MarkDeprecated("name", "use the --config-name flag") | ||
| cmd.Flags().StringVar(&b.url, "url", "", "The host url (required)") |
jsteenb2
force-pushed
the
18706/influx_config_host_parse
branch
from
e44e739
to
caccb66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18706
note: ignore white space for this PR, makes this body of work pretty small