Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(defaultAggregate): Add aggregate function by default in Query Builder #18841

Closed
wants to merge 44 commits into from
Closed

feat(defaultAggregate): Add aggregate function by default in Query Builder #18841

wants to merge 44 commits into from

Conversation

ebb-tide
Copy link
Contributor

@ebb-tide ebb-tide commented Jul 2, 2020 •
edited
Loading

Closes #18831

Describe your proposed changes here.

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Documentation updated or issue created (provide link to issue/pr)
  • Signed CLA (if not already signed)

@ebb-tide ebb-tide force-pushed the deniz-aggregate-window branch 2 times, most recently from f91f10d to 94210d1 Compare July 2, 2020 19:34
@ebb-tide ebb-tide changed the title Deniz aggregate window (WIP) feat(defaultAggregate): Add aggregate function by default in Query Builder Jul 2, 2020
@ebb-tide ebb-tide requested review from a team and zoesteinkamp and removed request for a team July 2, 2020 19:43
121watts
121watts reviewed Jul 2, 2020
View reviewed changes
Copy link
Contributor

@121watts 121watts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test plz

@ebb-tide ebb-tide force-pushed the deniz-aggregate-window branch 2 times, most recently from 7ef4b77 to a20686a Compare July 9, 2020 16:10
@ebb-tide ebb-tide requested a review from a team as a code owner July 16, 2020 20:27
121watts
121watts approved these changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@121watts 121watts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really solid work here. My only gripe is the booleans. Won't block on it. Do what you think is best.

ui/src/timeMachine/actions/queryBuilder.ts Outdated Show resolved Hide resolved
ui/src/timeMachine/components/AggregationSelector.tsx Outdated Show resolved Hide resolved
ui/src/timeMachine/components/AggregationSelector.tsx Outdated Show resolved Hide resolved
ui/src/timeMachine/reducers/index.ts Outdated Show resolved Hide resolved
ui/src/utils/defaultAggregate.test.ts Outdated Show resolved Hide resolved
ui/src/utils/defaultAggregate.test.ts Outdated Show resolved Hide resolved
ui/src/utils/defaultAggregate.ts Outdated Show resolved Hide resolved
@ebb-tide ebb-tide changed the title feat(defaultAggregate): Add aggregate function by default in Query Builder WIP !! feat(defaultAggregate): Add aggregate function by default in Query Builder Jul 16, 2020
@ebb-tide ebb-tide changed the title WIP !! feat(defaultAggregate): Add aggregate function by default in Query Builder feat(defaultAggregate): Add aggregate function by default in Query Builder Jul 23, 2020
@ebb-tide ebb-tide force-pushed the deniz-aggregate-window branch 3 times, most recently from c64ea83 to e1732a8 Compare July 23, 2020 23:13
121watts
121watts approved these changes Jul 24, 2020
View reviewed changes
Copy link
Contributor

@121watts 121watts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks solid. amendment to the current e2e tests then 👍

ui/src/timeMachine/actions/queryBuilder.ts Show resolved Hide resolved
@ebb-tide
feat(autoAgg): Add fillValues to backend
83f6b78
@ebb-tide
feat(autoAgg): default FillVales to true
309934d
@ebb-tide
feat(autoAgg): apply proper autoAggregateRequirements
5e85086
@ebb-tide
feat(autoAgg): remove isAutoWindowPeriod
d12e01a
@ebb-tide
feat(autoAgg): remove isAutoFunction
ce91ee8
@ebb-tide
feat(autoAgg): test one more thing
8f82f27
@ebb-tide
feat(autoAgg): Add space
a4a6b6b
@ebb-tide
feat(autoAgg): fix little things
4ffda31
@ebb-tide
feat(autoAgg): modernize queryBuilder actions
722203c
@ebb-tide
feat(autoAgg): get js tests to pass
2b937bd
@ebb-tide
feat(autoAgg): Fix check tests
62e8609
@ebb-tide
feat(autoAgg): fix pkger test
799d608
@ebb-tide
feat(autoAgg): Make components reasonable
26a364c
@ebb-tide
feat(autoAgg): refrain from adding createEmpty to check query if exists
ea70b3a
@ebb-tide
feat(autoAgg): Remove console
920ea27
@ebb-tide
feat(autoAgg): dont change other peoples stuff
aca357c
@ebb-tide
feat(autoAgg): Remove FunctionSelector
b36ab81
@ebb-tide
feat(autoAgg): get e2e to pass
32473b9
@ebb-tide
feat(autoAgg): Deemphasize text by changing color
0a96752
@ebb-tide
feat(autoAgg): Make the auto agg function more compact
13a036d
@ebb-tide
feat(autoAgg): Get autoAgg to work for checks
227b91e
@ebb-tide
feat(autoAgg): fix fillValues for check
3d1c9a0
@ebb-tide
feat(autoAgg): Add tooltip value
f666749
@ebb-tide
feat(autoAgg): Add cypress tests
f0a8724
@ebb-tide ebb-tide closed this Aug 17, 2020
@jacobmarble jacobmarble deleted the deniz-aggregate-window branch January 2, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@121watts 121watts 121watts approved these changes

@zoesteinkamp zoesteinkamp Awaiting requested review from zoesteinkamp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Query Builder queries must have an aggregate function.
3 participants
@ebb-tide @121watts @alexpaxton