Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't overwrite build date set via ldflags #18878

Merged
merged 1 commit into from Jul 7, 2020
Merged

fix: don't overwrite build date set via ldflags #18878

merged 1 commit into from Jul 7, 2020

Conversation

glinton
Copy link
Contributor

@glinton glinton commented Jul 7, 2020

Closes #18628

Calling a function on variable definition appears to be run after ldflags are processed, overwriting anything set in the ldflags. This respects any ldflag settings

@glinton glinton requested a review from jsteenb2 July 7, 2020 21:21
jsteenb2
jsteenb2 approved these changes Jul 7, 2020
View reviewed changes
Copy link
Contributor

@jsteenb2 jsteenb2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 💯

@glinton glinton merged commit e4d33f1 into master Jul 7, 2020
@glinton glinton deleted the bugfix/18628 branch July 7, 2020 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsteenb2 jsteenb2 jsteenb2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

influx CLI: version command returns current and not real build date
2 participants
@glinton @jsteenb2