fix: allow custom set y-axis min to be 0 #18891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TCL735
requested review from
a team,
asalem1 and
hoorayimhelping
and removed request for
a team
121watts
approved these changes
Jul 8, 2020
| @@ -72,24 +71,158 @@ describe('getRemainingRange', () => { | |||
| } | |||
| expect(getRemainingRange([], timeRange, [null, null])).toEqual(null) | |||
| }) | |||
| it("should return the min y-axis if it's set", () => { | |||
| describe('should return a valid number from the stored domain as the min y-axis', () => { | |||
There was a problem hiding this comment.
nit here but can we please have a newline between each describe and it block?
hoorayimhelping
approved these changes
Jul 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18853
0 is a falsy value and was considered an unallowable custom set minimum value. We will allow 0 and guard against NaN and Infinity instead.