Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add time taken for request to the http server logs #1974

Merged
merged 2 commits into from
Mar 16, 2015

Conversation

corylanou
Copy link
Contributor

This will add a field to the end of the http log for time that it took to execute the request. This is helpful for debugging.

[http] 2015/03/16 12:40:58 127.0.0.1 - - [16/Mar/2015:12:40:58 -0600] GET /query?db=foo&q=show+databases HTTP/1.1 200 62 - InfluxDBShell/0.9 fcc9cc32-cc0b-11e4-919b-60f81dab26ba 1.864595ms

@toddboom
Copy link
Contributor

@corylanou rad! this is a nice one.

@otoolep
Copy link
Contributor

otoolep commented Mar 16, 2015

@corylanou -- is this about showing the user how long the operation took? If so I think it would be better if it came back in the response body. That way we can include lots of useful information for the user like how long it took to process the query, the number of shards hit, etc etc.

@corylanou
Copy link
Contributor Author

@otoolep I would look at that as a separate feature request to this one.

@toddboom
Copy link
Contributor

👍

toddboom added a commit that referenced this pull request Mar 16, 2015
Add time taken for request to the http server logs
@toddboom toddboom merged commit 98b96d3 into master Mar 16, 2015
@corylanou corylanou deleted the http-log-time-since branch April 23, 2015 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants