Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(upgrade): use 10 instead of MaxInt when rewriting query-concurrency #19959

Merged
merged 1 commit into from
Nov 10, 2020

Conversation

danxmoran
Copy link
Contributor

Closes #19958

MaxInt was conceptually as close as we could get to the old default of 0, but it caused problems in practice. Use the new default value of 10 instead.

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Feature flagged (if modified API)
  • Documentation updated or issue created (provide link to issue/pr)
  • Signed CLA (if not already signed)

Copy link
Contributor

@stuartcarnie stuartcarnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fast turn around 🐎

@danxmoran danxmoran merged commit b643482 into master Nov 10, 2020
@danxmoran danxmoran deleted the dm-concurrency-upgrade-use-default-19958 branch November 10, 2020 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic when starting influxd after upgrade
2 participants