Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cmd/influxd): use a better default for upgraded V2 config, and allow users to override it #20110

Merged
merged 6 commits into from
Nov 23, 2020
Merged

feat(cmd/influxd): use a better default for upgraded V2 config, and allow users to override it #20110

merged 6 commits into from
Nov 23, 2020

Conversation

danxmoran
Copy link
Contributor

@danxmoran danxmoran commented Nov 19, 2020 •
edited
Loading

Closes #20104

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Feature flagged (if modified API)
  • Documentation updated or issue created (provide link to issue/pr)
  • Signed CLA (if not already signed)

ayang64
ayang64 suggested changes Nov 20, 2020
View reviewed changes
cmd/influxd/upgrade/config.go Outdated Show resolved Hide resolved
cmd/influxd/upgrade/config.go Outdated Show resolved Hide resolved
docmerlin
docmerlin approved these changes Nov 20, 2020
View reviewed changes
Copy link
Contributor

@docmerlin docmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, with minor nit, which you can ignore. Can you put periods at the end of the sentences in your CHANGELOG changes?

cmd/influxd/upgrade/config.go Outdated Show resolved Hide resolved
@danxmoran
Copy link
Contributor Author

@ayang64 Tim gave a 👍 to removing the fallback case, can you take another look?

ayang64
ayang64 approved these changes Nov 23, 2020
View reviewed changes
Copy link
Contributor

@ayang64 ayang64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@danxmoran danxmoran merged commit 89764ad into master Nov 23, 2020
@danxmoran danxmoran deleted the dm-upgrade-config-path-20104 branch November 23, 2020 18:05
danxmoran added a commit that referenced this pull request Nov 23, 2020
@danxmoran
feat(cmd/influxd): use a better default for upgraded V2 config, and a…
22bc715 
…llow users to override it (#20110)
@danxmoran danxmoran mentioned this pull request Nov 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@docmerlin docmerlin docmerlin approved these changes

@ayang64 ayang64 ayang64 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

influxd upgrade writes config.toml to a confusing location
3 participants
@danxmoran @docmerlin @ayang64