-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tasks): CLI method to Find and Rerun failed Runs #20307
Conversation
ignore test files for now. Need to implement builder pattern to make task.go testable. |
Drive-by comment: please make sure to add a line to |
Note to self (and others reading): I was a bit slow making tests for the other subcommands, but wanted to push and show something passing. |
@Nav-aggarwal09 let me know when you think this is ready and I'll dig into the review |
11a1bdf
to
3c7a48d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finishing review for now so I can see latest commits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments on the test suite
@danxmoran Sorry I think I was cleaning up some last minute things while you were reviewing. So there are 2 things I did:
I didn't write all the tests since that's outside the scope of this PR (i think, since I was told it's a proposal), but it should provide the backbone and bare minimum for others to follow and build off of. I will edit the code right now based on your review, and will ping you again soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your patience, I'll take a deeper look later today but noticed something easy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. One more adjustment and I'm happy :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Talked with @gavincabbage on Slack, and decided that switching the name & default behavior of the CLI option is good 👍 left suggestions for the spots I saw that should change, but might have missed some spots
Co-authored-by: Daniel Moran <danxmoran@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build failure is a known flaky thing, ok to ignore. Merging! |
we made it 🙏 |
This PR aims to provide a CLI function to rerun failed runs.
If a specific taskID is given, it will rerun the runs with status "failed".
If no taskID is given, it will find all tasks and their associated "failed" runs and rerun them.
The proposal also begs the question whether this function can be added to the server side.