fix(onboarding): don't ignore failures to set initial password #20317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danxmoran
commented
Dec 11, 2020
danxmoran
force-pushed
the
dm-no-ignore-password-err-20088
branch
from
b7473ea
to
4b2f68c
Compare
davidby-influx
approved these changes
Dec 15, 2020
| @@ -98,7 +107,18 @@ func (s *OnboardService) onboardUser(ctx context.Context, req *influxdb.Onboardi | |||
|
|
|||
| // create users password | |||
| if req.Password != "" { | |||
| s.service.SetPassword(ctx, user.ID, req.Password) | |||
| if err := s.service.SetPassword(ctx, user.ID, req.Password); err != nil { | |||
There was a problem hiding this comment.
This looks like the best you can do in cascading errors. Nice that you return the original error here, not the cleanup error. +1
danxmoran
force-pushed
the
dm-no-ignore-password-err-20088
branch
from
4b2f68c
to
ff16703
Compare
docmerlin
approved these changes
Dec 16, 2020
danxmoran
added a commit
that referenced
this pull request
Dec 16, 2020
danxmoran
added a commit
that referenced
this pull request
Dec 17, 2020
danxmoran
added a commit
that referenced
this pull request
Dec 18, 2020
danxmoran
added a commit
that referenced
this pull request
Dec 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20088
This was the most obvious problem with the onboarding path's handling of passwords. There's also a lot of duplication in the CLI with slight differences between the onboarding paths for interactive vs. noninteractive runs and the
influx setupvs.influxd upgraderuns, but I'm leaving that refactor for a follow-up PR.