fix(influxql): set correct Content-Type on v1 query responses #20565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danxmoran
force-pushed
the
dm-v1-content-type-20514
branch
from
3dcef51
to
5baf4ee
Compare
stuartcarnie
approved these changes
Jan 21, 2021
There was a problem hiding this comment.
Looks good, @danxmoran – I'd caution against logging the invalid accept headers to the logs, as these represent a client issue rather than a server issue. You could consider logging them as Debug level, which should be excluded from regular logs, but they are not a warning that an administrator needs to worry about.
http/legacy/influxqld_handler.go
Outdated
| formatString := r.Header.Get("Accept") | ||
| encodingFormat := influxql.EncodingFormatFromMimeType(formatString) | ||
| if encodingFormat == influxql.EncodingFormatUnknown { | ||
| h.Logger.Warn("request included unknown format in Accept header, using application/json", zap.String("format", formatString)) |
There was a problem hiding this comment.
Not sure there is value in logging invalid Accept headers. It is a client issue and could result in spamming the logs.
Comment on lines
+117
to
+127
| - in: header | ||
| name: Accept | ||
| schema: | ||
| type: string | ||
| description: Specifies how query results should be encoded in the response. | ||
| default: application/json | ||
| enum: | ||
| - application/json | ||
| - application/csv | ||
| - text/csv | ||
| - application/x-msgpack |
danxmoran
force-pushed
the
dm-v1-content-type-20514
branch
from
e7ba94a
to
f4f3a95
Compare
mohammadali-seifkashani
added a commit
to mohammadali-seifkashani/influxdb
that referenced
this pull request
Jan 23, 2021
fix(influxql): set correct Content-Type on v1 query responses (influxdata#20565)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20514
See reasoning for this approach in the issue.