fix(tsm1): fix data race when accessing tombstone stats #20773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danxmoran
commented
Feb 18, 2021
| } | ||
| if stats.Size > 0 { | ||
| return true | ||
| } |
There was a problem hiding this comment.
Not sure if it's worth the verbosity to avoid the extra lock below
There was a problem hiding this comment.
I think it's good as long as a non-zero size always means there are tombstones.
There was a problem hiding this comment.
It's the same end behavior as before, at least
benbjohnson
approved these changes
Feb 18, 2021
| } | ||
| if stats.Size > 0 { | ||
| return true | ||
| } |
There was a problem hiding this comment.
I think it's good as long as a non-zero size always means there are tombstones.
dgnorton
approved these changes
Feb 18, 2021
docmerlin
reviewed
Feb 19, 2021
This was referenced Mar 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20622