fix(ui): respect 24 hour clock format and allow more choices #20856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TCL735
requested review from
danxmoran,
a team and
jrenee42
and removed request for
a team
TCL735
changed the title
TCL735
force-pushed
the
fix_ui_768_time_formats
branch
from
db94ecc
to
9768744
Compare
|
@danxmoran @jrenee42 merge conflicts resolved and corresponding UI PR has been merged. Please review. |
danxmoran
approved these changes
Mar 4, 2021
| @@ -32,6 +32,7 @@ the endpoint has been removed. Use the `/metrics` endpoint to collect system sta | |||
| 1. [20819](https://github.com/influxdata/influxdb/pull/20819): Fix Single Stat graphs with thresholds crashing on negative values. | |||
| 1. [20809](https://github.com/influxdata/influxdb/pull/20809): Fix InfluxDB port in Flux function UI examples. Thanks @sunjincheng121! | |||
| 1. [20827](https://github.com/influxdata/influxdb/pull/20827): Remove unauthenticated, unsupported `/debug/vars` HTTP endpoint. | |||
| 1. [20856](https://github.com/influxdata/influxdb/pull/20856): Respect 24 hour clock formats in the UI and allow more choices | |||
There was a problem hiding this comment.
Nitpick question: should this be a feature instead of a bug fix?
There was a problem hiding this comment.
No, it's a bug fix. We've always intended to have the 24 hour clock but it was not properly rendered.
There was a problem hiding this comment.
... and the additional choices are very minor. In case a user had gotten used to the 12 hour clock by picking one of the 24 clock options previously, they can still keep that format by selecting one of the new choices.
|
I have added a commit to include Tables with the fix. This is in keeping with influxdata/ui#780 |
TCL735
force-pushed
the
fix_ui_768_time_formats
branch
from
7067acf
to
67ab47e
Compare
|
The force push was to get latest from master. |
This was referenced Mar 5, 2021
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes influxdata/ui#768
Identical to change made in InfluxDB Cloud UI. See influxdata/ui#772