Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: structured logging for HTTP server ErrorLog #21235

Merged
merged 2 commits into from
Apr 15, 2021

Conversation

williamhbaker
Copy link
Contributor

Closes #20740

This change makes the httpLogger available to the top-level http.Server via the ErrorLog property to ensure that errors from the server will follow the standard logging format used everywhere else.

Copy link
Contributor

@danxmoran danxmoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@williamhbaker williamhbaker merged commit 1d431e8 into master Apr 15, 2021
@williamhbaker williamhbaker deleted the wb-http-server-error-logs-20740 branch April 16, 2021 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors from HTTP server don't use our standard logging format
2 participants