fix(query): avoid breaking query config validation when upgrading from older versions #21325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…id (#21321) * test: refactor upgrade test to cover the config upgrade * fix: ensure upgraded query config is valid
…21324) * fix(query): accept queue-size > 0 when concurrency = 0 * fix(influxd): revert defaults for query settings to avoid validation err * test: lower the default query concurrency used by test launchers
davidby-influx
approved these changes
Apr 28, 2021
| @@ -205,11 +205,11 @@ func NewOpts(viper *viper.Viper) *InfluxdOpts { | |||
|
|
|||
| NoTasks: false, | |||
|
|
|||
| ConcurrencyQuota: 0, | |||
| ConcurrencyQuota: 1024, | |||
There was a problem hiding this comment.
Were you going to lower this because of the goproc limit?
There was a problem hiding this comment.
I think you saw in the original PR, but: the limits are lowered in the test launcher. See launcher_helpers.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21319
Backports #21321 and #21324
query-concurrencyandquery-queue-sizeto avoid validation failures for upgrading users.query-concurrencyis 0 andquery-queue-sizeis > 0.