Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change static legend's hide property to show #21648

Merged
merged 2 commits into from
Jun 10, 2021

Conversation

TCL735
Copy link
Contributor

@TCL735 TCL735 commented Jun 9, 2021

In support of influxdata/ui#1666

On the backend, static legend's properties must always be tracked. For hide there are really 3 states: true, false, or not set.

This is different than on the frontend, where Giraffe sees a lack of a "static legend" object to mean that static legend is not desired. And static legend's hide property is for convenience; it is a way to temporarily hide the static legend without removing (and later rebuilding) the entire object. Thus it is the static legend object itself that is analogous to the backend's hide property -- and has 3 states: staticLegend.hide is true, staticLegend.hide is false, or the lack of staticLegend.

Thus, on the backend we should change hide to show to accurately reflect "not set" to be the same as false.

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Feature flagged (if modified API)
  • Documentation updated or issue created (provide link to issue/pr)
  • Signed CLA (if not already signed)

@TCL735 TCL735 requested a review from a team as a code owner June 9, 2021 21:51
@TCL735 TCL735 requested a review from williamhbaker June 9, 2021 21:55
Copy link
Contributor

@williamhbaker williamhbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR & for the detailed explanation!

@TCL735 TCL735 merged commit 354c385 into master Jun 10, 2021
@TCL735 TCL735 deleted the fix_ui_1666_static_legend_show_instead branch June 10, 2021 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants