Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add route to return platform known resources #22135

Merged
merged 2 commits into from
Aug 10, 2021
Merged

Conversation

glinton
Copy link
Contributor

@glinton glinton commented Aug 9, 2021

This will add a route to return resources known to the platform. This allows the ui to generate an all-access token in a more uniform, and less brittle, way between cloud and oss.

Copy link
Contributor

@williamhbaker williamhbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This will help with influxdata/influx-cli#66 as well.

@glinton
Copy link
Contributor Author

glinton commented Aug 9, 2021

My biggest concern with this pr is that the list of resources returned aren't filtered in any way. If user doesn't have access to buckets, for example, they will still be responded with buckets as a supported resource. This is only an issue when paired with the use case of using this list to create an all-access token. I don't know how often that particular scenario would likely occur, but reinforces the need to handle the unauthorized errors when trying to grant permission to something the requester doesn't have access to.

@glinton glinton merged commit 7aaba33 into master Aug 10, 2021
@glinton glinton deleted the feat/i11025 branch August 18, 2021 23:26
lesam pushed a commit to lesam/influxdb that referenced this pull request Sep 24, 2021
lesam pushed a commit to lesam/influxdb that referenced this pull request Sep 24, 2021
lesam added a commit that referenced this pull request Sep 24, 2021
(cherry picked from commit 7aaba33)

Co-authored-by: Greg <2653109+glinton@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants