Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode all integer types #2376

Merged
merged 5 commits into from
Apr 22, 2015
Merged

Encode all integer types #2376

merged 5 commits into from
Apr 22, 2015

Conversation

otoolep
Copy link
Contributor

@otoolep otoolep commented Apr 21, 2015

This changes address two issues.

  • When encoding integers, int and int32 are encoded as int64.
  • When adding the path information for a shard to the diagnostics, a distinct array was added to the existing array. Instead the existing array should have had a new element appended to it.
  • An integration test was added, which simply checks that when self-monitoring is enabled and occurs, that the database stays up. Also added explicit checks for negative values.

@jtakkala
Copy link
Contributor

CLA for 443444c (#2366) signed.

@otoolep otoolep force-pushed the diags_types branch 2 times, most recently from da5f5e5 to 96a92c8 Compare April 22, 2015 02:27
@corylanou
Copy link
Contributor

+1

@otoolep
Copy link
Contributor Author

otoolep commented Apr 22, 2015

Thanks @corylanou

otoolep added a commit that referenced this pull request Apr 22, 2015
@otoolep otoolep merged commit 20ee9e3 into master Apr 22, 2015
@otoolep otoolep deleted the diags_types branch April 22, 2015 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants