fix(tsi1/partition/test): fix data race in test code #24613

philjb · 2024-01-30T00:32:20Z

TestPartition_Compact_Write_Fail test was not locking the partition before changing the value of MaxLogFileSize. This PR exports the mutex of the partition to allow the test to access it and lock. Alternatives require more changes such as a Setter method if we need to hide the mutex.

fixes data race between test and product code in partition compaction [Port to master-1.x] #24042, for data race between test and product code in partition compaction #24040

Closes #

Describe your proposed changes here.

I've read the contributing section of the project README.
Signed CLA (if not already signed).

davidby-influx

LGTM

TestPartition_Compact_Write_Fail test was not locking the partition before changing the value of MaxLogFileSize. This PR exports the mutex of the partition to allow the test to access it and lock. Alternatives require more changes such as a Setter method if we need to hide the mutex. * fixes #24042, for #24040

The flux test is another failing test because it was using a relative time range.

* fix(tsi1/partition/test): fix data race in test code TestPartition_Compact_Write_Fail test was not locking the partition before changing the value of MaxLogFileSize. This PR exports the mutex of the partition to allow the test to access it and lock. Alternatives require more changes such as a Setter method if we need to hide the mutex. * fixes #24042, for #24040 * chore: complete renaming of mutex in file and fix flux test The flux test is another failing test because it was using a relative time range.

* fix: update broken flux and perf tests (main-2.x) (#24617) * chore: download repository key to file * fix: broken perf tests Some perf tests had to be temporarily disabled. Work is needed in the pref_tests repositories to make them work again. * fix(tsi1/partition/test): fix data race in test code (#24613) * fix(tsi1/partition/test): fix data race in test code TestPartition_Compact_Write_Fail test was not locking the partition before changing the value of MaxLogFileSize. This PR exports the mutex of the partition to allow the test to access it and lock. Alternatives require more changes such as a Setter method if we need to hide the mutex. * fixes #24042, for #24040 * chore: complete renaming of mutex in file and fix flux test The flux test is another failing test because it was using a relative time range. --------- Co-authored-by: Phil Bracikowski <13472206+philjb@users.noreply.github.com>

…ck (#24613)

* feat: add hook for optimizing series reads based on authorizer (#25207) * fix(edge): Backporting #24613 in to 1.11 * fix(test): fixes typo from merge in test * fix(testing): adds error checking to cleanups --------- Co-authored-by: Geoffrey Wossum <gwossum@influxdata.com>

* fix(tsi1/partition/test): fix data races in test code This PR is like #24613 but solves it with a setter method for MaxLogFileSize which allows unexporting that value and MaxLogFileAge. There are actually two places locks were needed in test code. The behavior of production code is unchanged. (cherry picked from commit f0235c4daf4b97769db932f7346c1d3aecf57f8f)

* fix(tsi1/partition/test): fix data races in test code (#57) * fix(tsi1/partition/test): fix data races in test code This PR is like #24613 but solves it with a setter method for MaxLogFileSize which allows unexporting that value and MaxLogFileAge. There are actually two places locks were needed in test code. The behavior of production code is unchanged. (cherry picked from commit f0235c4daf4b97769db932f7346c1d3aecf57f8f) * feat: modify error handling to be more idiomatic closes #24042 * fix: errors.Join() filters nil errors --------- Co-authored-by: Phil Bracikowski <13472206+philjb@users.noreply.github.com>

* fix(tsi1/partition/test): fix data races in test code (#57) * fix(tsi1/partition/test): fix data races in test code This PR is like #24613 but solves it with a setter method for MaxLogFileSize which allows unexporting that value and MaxLogFileAge. There are actually two places locks were needed in test code. The behavior of production code is unchanged. (cherry picked from commit f0235c4daf4b97769db932f7346c1d3aecf57f8f) * feat: modify error handling to be more idiomatic closes #24042 * fix: errors.Join() filters nil errors closes #25341 --------- Co-authored-by: Phil Bracikowski <13472206+philjb@users.noreply.github.com> (cherry picked from commit 5c9e45f)

* fix(tsi1/partition/test): fix data races in test code (#57) * fix(tsi1/partition/test): fix data races in test code This PR is like #24613 but solves it with a setter method for MaxLogFileSize which allows unexporting that value and MaxLogFileAge. There are actually two places locks were needed in test code. The behavior of production code is unchanged. (cherry picked from commit f0235c4daf4b97769db932f7346c1d3aecf57f8f) * feat: modify error handling to be more idiomatic closes #24042 * fix: errors.Join() filters nil errors --------- Co-authored-by: Phil Bracikowski <13472206+philjb@users.noreply.github.com> (cherry picked from commit 5c9e45f)

…25345) * feat: add hook for optimizing series reads based on authorizer (#25207) * fix(tsi1/partition/test): fix data races in test code (#57) (#25338) * fix(tsi1/partition/test): fix data races in test code (#57) * fix(tsi1/partition/test): fix data races in test code This PR is like #24613 but solves it with a setter method for MaxLogFileSize which allows unexporting that value and MaxLogFileAge. There are actually two places locks were needed in test code. The behavior of production code is unchanged. (cherry picked from commit f0235c4daf4b97769db932f7346c1d3aecf57f8f) * feat: modify error handling to be more idiomatic closes #24042 * fix: errors.Join() filters nil errors --------- Co-authored-by: Phil Bracikowski <13472206+philjb@users.noreply.github.com> (cherry picked from commit 5c9e45f) --------- Co-authored-by: Geoffrey Wossum <gwossum@influxdata.com>

…25344) * fix(tsi1/partition/test): fix data races in test code (#57) * fix(tsi1/partition/test): fix data races in test code This PR is like #24613 but solves it with a setter method for MaxLogFileSize which allows unexporting that value and MaxLogFileAge. There are actually two places locks were needed in test code. The behavior of production code is unchanged. (cherry picked from commit f0235c4daf4b97769db932f7346c1d3aecf57f8f) * feat: modify error handling to be more idiomatic closes #24042 * fix: errors.Join() filters nil errors closes #25341 --------- Co-authored-by: Phil Bracikowski <13472206+philjb@users.noreply.github.com> (cherry picked from commit 5c9e45f)

…25344) * fix(tsi1/partition/test): fix data races in test code (#57) * fix(tsi1/partition/test): fix data races in test code This PR is like #24613 but solves it with a setter method for MaxLogFileSize which allows unexporting that value and MaxLogFileAge. There are actually two places locks were needed in test code. The behavior of production code is unchanged. (cherry picked from commit f0235c4daf4b97769db932f7346c1d3aecf57f8f) * feat: modify error handling to be more idiomatic closes #24042 * fix: errors.Join() filters nil errors closes #25341 --------- Co-authored-by: Phil Bracikowski <13472206+philjb@users.noreply.github.com> (cherry picked from commit 5c9e45f) (cherry picked from commit b88e74e) closes #25342

…nstead of panic when type of time != float #57) fix(tsi1/partition/test): fix data races in test code This PR is like #24613 but solves it with a setter method for MaxLogFileSize which allows unexporting that value and MaxLogFileAge. There are actually two places locks were needed in test code. The behavior of production code is unchanged. (cherry picked from commit f0235c4daf4b97769db932f7346c1d3aecf57f8f) feat: modify error handling to be more idiomatic closes #24042 fix: errors.Join() filters nil errors closes #25341 --------- Co-authored-by: Phil Bracikowski 13472206+philjb@users.noreply.github.com (cherry picked from commit 5c9e45f) (cherry picked from commit b88e74e) closes #25342

* fix(tsi1/partition/test): fix data races in test code (#57) * fix(tsi1/partition/test): fix data races in test code This PR is like #24613 but solves it with a setter method for MaxLogFileSize which allows unexporting that value and MaxLogFileAge. There are actually two places locks were needed in test code. The behavior of production code is unchanged. (cherry picked from commit f0235c4daf4b97769db932f7346c1d3aecf57f8f) * feat: modify error handling to be more idiomatic closes #24042 * fix: errors.Join() filters nil errors closes #25341 --------- Co-authored-by: Phil Bracikowski <13472206+philjb@users.noreply.github.com> (cherry picked from commit 5c9e45f) (cherry picked from commit b88e74e) closes #25342

#25352) * fix(tsi1/partition/test): fix data races in test code (#57) * fix(tsi1/partition/test): fix data races in test code This PR is like #24613 but solves it with a setter method for MaxLogFileSize which allows unexporting that value and MaxLogFileAge. There are actually two places locks were needed in test code. The behavior of production code is unchanged. (cherry picked from commit f0235c4daf4b97769db932f7346c1d3aecf57f8f) * feat: modify error handling to be more idiomatic closes #24042 * fix: errors.Join() filters nil errors closes #25341 --------- Co-authored-by: Phil Bracikowski <13472206+philjb@users.noreply.github.com> (cherry picked from commit 5c9e45f) (cherry picked from commit b88e74e) closes #25342

… (#25438) * feat: add hook for optimizing series reads based on authorizer (#25207) * fix(tsi1/partition/test): fix data races in test code (#57) (#25338) * fix(tsi1/partition/test): fix data races in test code (#57) * fix(tsi1/partition/test): fix data races in test code This PR is like #24613 but solves it with a setter method for MaxLogFileSize which allows unexporting that value and MaxLogFileAge. There are actually two places locks were needed in test code. The behavior of production code is unchanged. (cherry picked from commit f0235c4daf4b97769db932f7346c1d3aecf57f8f) * feat: modify error handling to be more idiomatic closes #24042 * fix: errors.Join() filters nil errors --------- Co-authored-by: Phil Bracikowski <13472206+philjb@users.noreply.github.com> (cherry picked from commit 5c9e45f) * fix(ci): Update test_pkgs_64bit image to non-eol ubuntu image (#25354) * fix(ci): Update test_pkgs_64bit image to non-eol ubuntu image * fix: trying edge img * fix(ci): update ubuntu image in ci Update test_pkgs_64bit image to non-eol ubuntu image Please see: discuss.circleci.com/t/linux-image-deprecations-and-eol-for-2024/50177 closes #25355 (cherry picked from commit fdf0df7) --------- Co-authored-by: Geoffrey Wossum <gwossum@influxdata.com>

philjb changed the title ~~chore: rename master to main-2.x~~ fix(tsi1/partition/test): fix data race in test code Jan 30, 2024

philjb requested a review from davidby-influx January 30, 2024 00:32

davidby-influx approved these changes Jan 30, 2024

View reviewed changes

philjb force-pushed the pjb-24040-data-race branch from d7d1a44 to f7858bd Compare January 30, 2024 00:34

chore: complete renaming of mutex in file and fix flux test

7284257

The flux test is another failing test because it was using a relative time range.

philjb merged commit 713efbc into main-2.x Jan 31, 2024
24 of 25 checks passed

philjb deleted the pjb-24040-data-race branch January 31, 2024 04:01

philjb mentioned this pull request Jan 31, 2024

Port: test failures to 2.7.x and other release branches from main-2.x #24614

Open

devanbenz mentioned this pull request Sep 6, 2024

fix(tsi1/partition/test): fix data race in test code #25288

Merged

2 tasks

devanbenz pushed a commit that referenced this pull request Sep 7, 2024

chore(back-port): finish cherry pick and resolve merges for cherry pi…

393297a

…ck (#24613)

devanbenz added a commit that referenced this pull request Sep 9, 2024

fix(edge): Backporting #24613 in to 1.11

8014a02

devanbenz mentioned this pull request Sep 16, 2024

fix(tsi1/partition/test): fix data races in test code (#57) #25336

Merged

2 tasks

devanbenz mentioned this pull request Sep 16, 2024

fix(tsi1/partition/test): fix data races in test code (#57) #25338

Merged

2 tasks

devanbenz mentioned this pull request Sep 17, 2024

fix(tsi1/partition/test): fix data races in test code (#57) (#25338) #25344

Merged

2 tasks

devanbenz mentioned this pull request Sep 17, 2024

fix(tsi1/partition/test): fix data races in test code (#57) (#25338) #25345

Merged

devanbenz mentioned this pull request Sep 17, 2024

fix(tsi1/partition/test): fix data races in test code (#57) (#25338) … #25352

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(tsi1/partition/test): fix data race in test code #24613

fix(tsi1/partition/test): fix data race in test code #24613

philjb commented Jan 30, 2024 •

edited

Loading

davidby-influx left a comment

fix(tsi1/partition/test): fix data race in test code #24613

fix(tsi1/partition/test): fix data race in test code #24613

Conversation

philjb commented Jan 30, 2024 • edited Loading

davidby-influx left a comment

Choose a reason for hiding this comment

philjb commented Jan 30, 2024 •

edited

Loading